Skip to content

resolve warnings about casing in Dockerfiles #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 6 commits into from
Jul 18, 2024
Merged

resolve warnings about casing in Dockerfiles #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f682ab4
resolve warnings about casing in Dockerfiles
jameslamb Jul 3, 2024
cba0063
Merge branch 'branch-24.08' into casing
jameslamb Jul 16, 2024
7935ac5
ensure execution_time is always in scope
jameslamb Jul 17, 2024
f9aec80
Merge branch 'casing' of github.com:jameslamb/docker into casing
jameslamb Jul 17, 2024
7be6b6b
Merge branch 'branch-24.08' into casing
jameslamb Jul 18, 2024
55d4d42
ruff
jameslamb Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ EOF


# Base image
FROM rapidsai/miniforge-cuda:cuda${CUDA_VER}-base-${LINUX_VER}-py${PYTHON_VER} as base
FROM rapidsai/miniforge-cuda:cuda${CUDA_VER}-base-${LINUX_VER}-py${PYTHON_VER} AS base
ARG CUDA_VER
ARG PYTHON_VER

Expand Down Expand Up @@ -67,7 +67,7 @@ CMD ["ipython"]


# Notebooks image
FROM base as notebooks
FROM base AS notebooks

ARG CUDA_VER
ARG LINUX_DISTRO
Expand Down
1 change: 1 addition & 0 deletions context/test_notebooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ def test_notebook(notebook_file, executed_nb_file):
warnings = []
outputs = []


# use nbconvert to run the notebook natively
ep = ExecutePreprocessor(timeout=600, kernel_name="python3", allow_errors=True)
task_init = timeit.default_timer()
Expand Down