Disable cuSpatial nightly packages and docs.#600
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
✅ My approval wouldn't count towards a merge here, but I approve. I did click around the preview and it looked to me like everything was working as expected.
For example, seeing cuSpatial / cuProj grayed out when choosing "Choose Specific Packages" and RAPIDS 25.06:
I left one suggestion for simplifying the code, but treat it as non-blocking... do it only if you want, I know testing these changes and be a bit time-consuming.
| // Hide cuSpatial and cuProj for Nightly | ||
| if (this.active_release === "Nightly") { | ||
| pkgs_to_show = pkgs_to_show.filter(pkg => pkg !== "cuSpatial" && pkg !== "cuProj"); | ||
| } |
There was a problem hiding this comment.
| // Hide cuSpatial and cuProj for Nightly | |
| if (this.active_release === "Nightly") { | |
| pkgs_to_show = pkgs_to_show.filter(pkg => pkg !== "cuSpatial" && pkg !== "cuProj"); | |
| } | |
| // possibly filter out any packages that are disabled in specific settings | |
| pkgs_to_show = pkgs_to_show.filter(pkg => !disableUnsupportedPackage(pkg)) |
My JavaScript is not the best, but is it possible to do something like this everywhere, instead of repeating the literals "cuSpatial" and "cuProj" in so many places?
Putting those filters in place would make it easier to do this kind of thing in the future, and reduce the effort to update the selector again when 25.06 becomes the stable version.
There was a problem hiding this comment.
Sort of. In theory this is a good idea. In practice, disableUnsupportedPackage accepts button labels as its argument, like cuSpatial/cuProj while we need to use actual package names like cuspatial and cuproj here. Someday we need to rewrite the selector logic from the ground up.
There was a problem hiding this comment.
blegh ok I see, I'd missed that distinction. Thanks for considering it.
|
|
||
| // Hide cuSpatial and cuProj for Nightly | ||
| if (this.active_release === "Nightly") { | ||
| pkgs_to_show = pkgs_to_show.filter(pkg => pkg !== "cuSpatial" && pkg !== "cuProj"); |
There was a problem hiding this comment.
If you select stable, Choose specific packages, and select cuspatial. Then switch to Nightly, the cuspatial button is disabled, but the install script will still include the packages.
There was a problem hiding this comment.
Ah, great. I'll try to fix.
3 participants
cuSpatial will not be published in 25.06: https://docs.rapids.ai/notices/rsn0045/
This PR drops cuSpatial from the nightly package selector and nightly docs.