Merged
Conversation
jameslamb
added
improvement
jameslamb
changed the title
jameslamb
changed the title
bdice
approved these changes
May 7, 2025
This was referenced May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #336
Contributes to https://github.com/rapidsai/build-infra/issues/237
Proposes the following for
{conda-cpp, conda-python, wheel}-build.yamlworkflows:upload-artifacts, to opt out of uploading GitHub Actions artifacts (see Make artifact uploads optional in build workflows #336 for reasoning)package-typeinput requiredpackage-typewas an empty stringNotes for Reviewers
Why are these
package-typechanges part of this? Are the safe?Stuff like this...
shared-workflows/.github/workflows/wheels-build.yaml
Lines 232 to 233 in 18279ec
... was added early on in the effort to support GitHub Actions artifact uploads in these workflows (#297), and made optional so those changes could be merged prior to all repos being migrated.
It's now safe to make this stricter. I searched all of the GitHub orgs I have read access to (GitHub search), and the only place where
package-typeis NOT provided is incuspatial: https://github.com/rapidsai/cuspatial/blob/c0f92e5b95f21ccc58d187689bb06adb2fd2bc56/.github/workflows/pr.yaml#L152-L160cuspatialsupport is getting dropped right now (rapidsai/docs#600), so we probably don't even need to update that one.How I tested this
rapidsai/integration#760