Skip to content

make artifact uploads optional #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 1 commit into from
May 7, 2025
Merged

make artifact uploads optional #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/conda-cpp-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ on:
script:
type: string
default: "ci/build_cpp.sh"
upload-artifacts:
type: boolean
default: true
required: false
description: "One of [true, false], true if artifacts should be uploaded to GitHub's artifact store"
matrix_filter:
type: string
default: "."
Expand Down Expand Up @@ -125,15 +130,18 @@ jobs:
STEP_NAME: "C++ build"
GH_TOKEN: ${{ github.token }}
- name: Get Package Name and Location
if: ${{ inputs.upload-artifacts }}
run: |
echo "RAPIDS_PACKAGE_NAME=$(RAPIDS_NO_PKG_EXTENSION=true rapids-package-name conda_cpp)" >> "${GITHUB_OUTPUT}"
echo "CONDA_OUTPUT_DIR=${RAPIDS_CONDA_BLD_OUTPUT_DIR}" >> "${GITHUB_OUTPUT}"
id: package-name
- name: Show files to be uploaded
if: ${{ inputs.upload-artifacts }}
run: |
echo "Contents of directory to be uploaded:"
ls -R ${{ steps.package-name.outputs.CONDA_OUTPUT_DIR }}
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload-artifacts }}
with:
name: ${{ steps.package-name.outputs.RAPIDS_PACKAGE_NAME }}
path: ${{ steps.package-name.outputs.CONDA_OUTPUT_DIR }}
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/conda-python-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ on:
script:
type: string
default: "ci/build_python.sh"
upload-artifacts:
type: boolean
default: true
required: false
description: "One of [true, false], true if artifacts should be uploaded to GitHub's artifact store"
matrix_filter:
type: string
default: "."
Expand Down Expand Up @@ -125,15 +130,18 @@ jobs:
env:
GH_TOKEN: ${{ github.token }}
- name: Get Package Name and Location
if: ${{ inputs.upload-artifacts }}
run: |
echo "RAPIDS_PACKAGE_NAME=$(RAPIDS_NO_PKG_EXTENSION=true rapids-package-name conda_python)" >> "${GITHUB_OUTPUT}"
echo "CONDA_OUTPUT_DIR=${RAPIDS_CONDA_BLD_OUTPUT_DIR}" >> "${GITHUB_OUTPUT}"
id: package-name
- name: Show files to be uploaded
if: ${{ inputs.upload-artifacts }}
run: |
echo "Contents of directory to be uploaded:"
ls -R ${{ steps.package-name.outputs.CONDA_OUTPUT_DIR }}
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload-artifacts }}
with:
name: ${{ steps.package-name.outputs.RAPIDS_PACKAGE_NAME }}
path: ${{ steps.package-name.outputs.CONDA_OUTPUT_DIR }}
Expand Down
13 changes: 9 additions & 4 deletions .github/workflows/wheels-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ on:
description: "Distribution name, without any other qualifiers (e.g. 'pylibcudf', not 'pylibcudf-cu12-cp311-manylinux_2_24_aarch64')"
package-type:
description: "One of: [cpp, python]"
required: false
required: true
type: string
wheel-name:
required: false
Expand All @@ -52,6 +52,11 @@ on:
matrix_filter:
type: string
default: "."
upload-artifacts:
type: boolean
default: true
required: false
description: "One of [true, false], true if artifacts should be uploaded to GitHub's artifact store"

# Extra repository that will be cloned into the project directory.
extra-repo:
Expand Down Expand Up @@ -200,7 +205,7 @@ jobs:
shell: bash -leo pipefail {0}

- name: Get package name
if: inputs.package-type != ''
if: ${{ inputs.upload-artifacts }}
env:
PACKAGE_TYPE: ${{ inputs.package-type }}
WHEEL_NAME: ${{ inputs.package-name != '' && inputs.package-name || inputs.wheel-name }}
Expand All @@ -224,13 +229,13 @@ jobs:
id: package-name

- name: Show files to be uploaded
if: inputs.package-type != ''
if: ${{ inputs.upload-artifacts }}
run: |
echo "Contents of directory to be uploaded:"
ls -R ${{ steps.package-name.outputs.WHEEL_OUTPUT_DIR }}

- uses: actions/upload-artifact@v4
if: inputs.package-type != ''
if: ${{ inputs.upload-artifacts }}
with:
name: ${{ steps.package-name.outputs.RAPIDS_PACKAGE_NAME }}
path: ${{ steps.package-name.outputs.WHEEL_OUTPUT_DIR }}
Expand Down