make input validation, upload logic in build workflows stricter#348
Merged
jameslamb merged 2 commits intobranch-25.06from May 14, 2025
Merged
make input validation, upload logic in build workflows stricter#348jameslamb merged 2 commits intobranch-25.06from
jameslamb merged 2 commits intobranch-25.06from
Conversation
jameslamb
commented
May 13, 2025
| - uses: actions/upload-artifact@v4 | ||
| if: ${{ inputs.upload-artifacts }} | ||
| with: | ||
| if-no-files-found: 'error' |
Member
Author
There was a problem hiding this comment.
Reference for this: https://github.com/actions/upload-artifact?tab=readme-ov-file#inputs
When actions/upload-artifact does not find any files to upload at {path}, by default it warns but does not error.
I think for our purposes, we want a big loud CI-failing error, as 0 files being found likely points to a misconfiguration. For any purposes where this workflow is run and you don't want to upload artifacts, we already have an opt-out via the upload-artifacts boolean input: #340
ajschmidt8
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #334
Contributes to https://github.com/rapidsai/build-infra/issues/237
Makes the following changes in the
wheels-buildworkflow:wheel-namepackage-namerequiredactions/upload-artifactto ERROR if no files are found to uploadNotes for Reviewers
Why, and why now?
When the work to transition artifact-handling from
downloads.rapids.aito GitHub Actions artifacts started, this input referring to the name of the project was calledwheel-name.We later decided that
package-namewas more appropriate, for consistency with other workflows:shared-workflows/.github/workflows/wheels-publish.yaml
Line 21 in 1ddf097
shared-workflows/.github/workflows/conda-cpp-build.yaml
Line 137 in 1ddf097
But by that time, some PRs calling it
wheel-namehad already been merged downstream. So both names were kept around for a bit.Now, there are 0 remaining uses of
wheel-nameacross therapidsaiorg: https://github.com/search?q=org%3Arapidsai+%22wheel-name%22&type=codeHow I tested this
Searched for
wheel-nameuses across therapidsaiorg and found none remaining: https://github.com/search?q=org%3Arapidsai+%22wheel-name%22&type=codeSearched for
wheels-build.yamlacross therapidsaiorg and found that every use of it was also explicitly supplying a value for inputpackage-name:: https://github.com/search?q=org%3Arapidsai+%22wheels-build.yaml%22+AND+NOT+is%3Aarchived&type=codeExcept these repos which are not being actively maintained, and which we've agreed not to worry about for this migration: