Skip to content

make input validation, upload logic in build workflows stricter#348

Merged
jameslamb merged 2 commits intobranch-25.06from
remove-wheel-name-input
May 14, 2025
Merged

make input validation, upload logic in build workflows stricter#348
jameslamb merged 2 commits intobranch-25.06from
remove-wheel-name-input

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented May 13, 2025

Replaces #334

Contributes to https://github.com/rapidsai/build-infra/issues/237

Makes the following changes in the wheels-build workflow:

  • removes input wheel-name
  • makes input package-name required
  • configures actions/upload-artifact to ERROR if no files are found to upload

Notes for Reviewers

Why, and why now?

When the work to transition artifact-handling from downloads.rapids.ai to GitHub Actions artifacts started, this input referring to the name of the project was called wheel-name.

We later decided that package-name was more appropriate, for consistency with other workflows:

But by that time, some PRs calling it wheel-name had already been merged downstream. So both names were kept around for a bit.

Now, there are 0 remaining uses of wheel-name across the rapidsai org: https://github.com/search?q=org%3Arapidsai+%22wheel-name%22&type=code

How I tested this

Searched for wheel-name uses across the rapidsai org and found none remaining: https://github.com/search?q=org%3Arapidsai+%22wheel-name%22&type=code

Searched for wheels-build.yaml across the rapidsai org and found that every use of it was also explicitly supplying a value for input package-name:: https://github.com/search?q=org%3Arapidsai+%22wheels-build.yaml%22+AND+NOT+is%3Aarchived&type=code

Except these repos which are not being actively maintained, and which we've agreed not to worry about for this migration:

@jameslamb jameslamb requested a review from ajschmidt8 May 13, 2025 21:42
@jameslamb jameslamb requested a review from a team as a code owner May 13, 2025 21:42
@jameslamb jameslamb added breaking Introduces a breaking change improvement Improves an existing functionality labels May 13, 2025
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload-artifacts }}
with:
if-no-files-found: 'error'
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference for this: https://github.com/actions/upload-artifact?tab=readme-ov-file#inputs

When actions/upload-artifact does not find any files to upload at {path}, by default it warns but does not error.

I think for our purposes, we want a big loud CI-failing error, as 0 files being found likely points to a misconfiguration. For any purposes where this workflow is run and you don't want to upload artifacts, we already have an opt-out via the upload-artifacts boolean input: #340

@jameslamb jameslamb changed the title wheels-build: make 'package-name' input required, remove 'wheel-name' make input validation, upload logic in build workflows stricter May 13, 2025
@jameslamb jameslamb merged commit 35e0ffc into branch-25.06 May 14, 2025
1 check passed
@jameslamb jameslamb deleted the remove-wheel-name-input branch May 14, 2025 15:48
@jameslamb jameslamb mentioned this pull request May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants