Skip to content

make input validation, upload logic in build workflows stricter #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 2 commits into from
May 14, 2025
Merged

make input validation, upload logic in build workflows stricter #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f0de2d
wheels-build: make 'package-name' input required, remove 'wheel-name'
jameslamb May 13, 2025
4b1a1d0
error out if no files to upload
jameslamb May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/conda-cpp-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ jobs:
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload-artifacts }}
with:
if-no-files-found: 'error'
name: ${{ steps.package-name.outputs.RAPIDS_PACKAGE_NAME }}
path: ${{ steps.package-name.outputs.CONDA_OUTPUT_DIR }}
- name: Upload additional artifacts
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/conda-python-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ jobs:
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload-artifacts }}
with:
if-no-files-found: 'error'
name: ${{ steps.package-name.outputs.RAPIDS_PACKAGE_NAME }}
path: ${{ steps.package-name.outputs.CONDA_OUTPUT_DIR }}
- name: Upload additional artifacts
Expand Down
19 changes: 8 additions & 11 deletions .github/workflows/wheels-build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,13 @@ on:
required: true
type: string
package-name:
required: false
required: true
type: string
description: "Distribution name, without any other qualifiers (e.g. 'pylibcudf', not 'pylibcudf-cu12-cp311-manylinux_2_24_aarch64')"
package-type:
description: "One of: [cpp, python]"
required: true
type: string
wheel-name:
required: false
type: string
description: "DEPRECATED: Use package-name instead"
pure-wheel:
required: false
type: boolean
Expand Down Expand Up @@ -211,19 +207,19 @@ jobs:
- name: Get package name
if: ${{ inputs.upload-artifacts }}
env:
APPEND_CUDA_SUFFIX: ${{ inputs.append-cuda-suffix }}
PACKAGE_NAME: ${{ inputs.package-name }}
PACKAGE_TYPE: ${{ inputs.package-type }}
WHEEL_NAME: ${{ inputs.package-name != '' && inputs.package-name || inputs.wheel-name }}
PURE_WHEEL: ${{ inputs.pure-wheel }}
APPEND_CUDA_SUFFIX: ${{ inputs.append-cuda-suffix }}
run: |
if [ -z "${WHEEL_NAME}" ]; then
WHEEL_NAME="${RAPIDS_REPOSITORY#*/}"
if [ -z "${PACKAGE_NAME}" ]; then
PACKAGE_NAME="${RAPIDS_REPOSITORY#*/}"
fi
export "RAPIDS_PY_CUDA_SUFFIX=$(rapids-wheel-ctk-name-gen ${RAPIDS_CUDA_VERSION})"
if [ "${APPEND_CUDA_SUFFIX}" = "true" ]; then
export "RAPIDS_PY_WHEEL_NAME=${WHEEL_NAME}_${RAPIDS_PY_CUDA_SUFFIX}"
export "RAPIDS_PY_WHEEL_NAME=${PACKAGE_NAME}_${RAPIDS_PY_CUDA_SUFFIX}"
else
export "RAPIDS_PY_WHEEL_NAME=${WHEEL_NAME}"
export "RAPIDS_PY_WHEEL_NAME=${PACKAGE_NAME}"
fi
if [ "${PURE_WHEEL}" = "true" ]; then
export "RAPIDS_PY_WHEEL_PURE=1"
Expand All @@ -241,6 +237,7 @@ jobs:
- uses: actions/upload-artifact@v4
if: ${{ inputs.upload-artifacts }}
with:
if-no-files-found: 'error'
Copy link
Copy Markdown
Member Author

@jameslamb jameslamb May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reference for this: https://github.com/actions/upload-artifact?tab=readme-ov-file#inputs

When actions/upload-artifact does not find any files to upload at {path}, by default it warns but does not error.

I think for our purposes, we want a big loud CI-failing error, as 0 files being found likely points to a misconfiguration. For any purposes where this workflow is run and you don't want to upload artifacts, we already have an opt-out via the upload-artifacts boolean input: #340

name: ${{ steps.package-name.outputs.RAPIDS_PACKAGE_NAME }}
path: ${{ steps.package-name.outputs.WHEEL_OUTPUT_DIR }}

Expand Down