[REVIEW] Add gather & gatherv to raft::comms::comms_t#114
Merged
cjnolet merged 6 commits intorapidsai:branch-0.18from Feb 3, 2021
Merged
[REVIEW] Add gather & gatherv to raft::comms::comms_t#114cjnolet merged 6 commits intorapidsai:branch-0.18from
cjnolet merged 6 commits intorapidsai:branch-0.18from
Conversation
Contributor
seunghwak
commented
Dec 10, 2020
seunghwak
commented
- Add gather & gatherv to raft::comms::comms_t, raft::comms::std_comms_t, and raft::comms::mpi_comms_t
seunghwak
changed the title
Contributor
Author
|
This addresses #114 |
cjnolet
requested changes
Dec 11, 2020
Member
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
The addition LGTM. Can you also expose a small test through test.hpp? Ideally we would also expose it to the Python layer for sanity checks.
Contributor
Author
Sure, I will. I will test this locally with cuGraph first, and then, I will add a test suite. |
dantegd
added
enhancement
afender
added
3 - Ready for Review
improvement
3 tasks
rapids-bot Bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Feb 25, 2021
…icast_sendrecv, gather, gatherv) (#1391) - [x] Update cuGraph to use RAFT::comms_t's newly added device_sendrecv & device_multicast_sendrecv) - [x] Update cuGraph to use RAFT::comms_t's newly added gather & gatherv - [x] Update RAFT git tag once rapidsai/raft#114 (currently merged in 0.18 but is not merged to 0.19) and rapidsai/raft#144 are merged to 0.19 Ready for review but cannot be merged till RAFT PR 114 and 144 are merged to RAFT branch-0.19. Authors: - Seunghwa Kang (@seunghwak) Approvers: - Alex Fender (@afender) URL: #1391
dantegd
pushed a commit
to dantegd/raft
that referenced
this pull request
Jul 23, 2024
Define `-DRAFT_HIDE_DEPRECATION_WARNINGS` added in rapidsai#2271. Authors: - Paul Taylor (https://github.com/trxcllnt) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#114
loulankxh
pushed a commit
to loulankxh/raft
that referenced
this pull request
Oct 14, 2025
[REVIEW] Add gather & gatherv to raft::comms::comms_t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.