Set correct compiler feature for generate_ctest_json#802
Merged
AyodeAwe merged 2 commits intorapidsai:branch-25.04from Mar 24, 2025
Merged
Conversation
Since rapidsai/shared-workflows#306, we now build and test with CUDA 11.4 and GCC 10, which does not use C++17 by default. To get the CUDA compiler to set C++17, we need to specify `cuda_std_17`. Fix how the compiler feature is set in CMake.
KyleFromNVIDIA
added
bug
robertmaynard
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since rapidsai/shared-workflows#306, we now build and test with CUDA 11.4 and GCC 10, which does not use C++17 by default. To get the CUDA compiler to set C++17, we need to specify
cuda_std_17. Fix how the compiler feature is set in CMake.Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))