chore: add cuda 11.4 to pull-request testing#306
Merged
vyasr merged 1 commit intorapidsai:branch-25.04from Mar 17, 2025
Merged
Conversation
bdice
approved these changes
Mar 17, 2025
vyasr
approved these changes
Mar 17, 2025
KyleFromNVIDIA
added a commit
to KyleFromNVIDIA/rapids-cmake
that referenced
this pull request
Mar 24, 2025
Since rapidsai/shared-workflows#306, we now build and test with CUDA 11.4 and GCC 10, which does not use C++17 by default. To get the CUDA compiler to set C++17, we need to specify `cuda_std_17`. Fix how the compiler feature is set in CMake.
7 tasks
AyodeAwe
pushed a commit
to rapidsai/rapids-cmake
that referenced
this pull request
Mar 24, 2025
## Description Since rapidsai/shared-workflows#306, we now build and test with CUDA 11.4 and GCC 10, which does not use C++17 by default. To get the CUDA compiler to set C++17, we need to specify `cuda_std_17`. Fix how the compiler feature is set in CMake. ## Checklist - [ ] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/rapids-cmake/blob/HEAD/CONTRIBUTING.md). - [ ] New or existing tests cover these changes. - [ ] The documentation is up to date with these changes. - [ ] The `cmake-format.json` is up to date with these changes. - [ ] I have added new files under rapids-cmake/ - [ ] I have added include guards (`include_guard(GLOBAL)`) - [ ] I have added the associated docs/ rst file and update the api.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves rapidsai/build-planning#164
This adds a CUDA 11.4 entry to the pull request matrix for
conda-cpp-testsandconda-python-tests.For now, I've just copied the entry from the nightly matrix.
PRs have been merged in raft, cuml, and cugraph to pre-filter this new job out to avoid breaking their CI.
rapidsai/raft#2608
rapidsai/cuml#6447
rapidsai/cugraph#4975