Fix issue with formatY function in Area and Bar charts #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawagner
reviewed
Jun 27, 2019
Owner
rawagner
left a comment
rawagner
left a comment
There was a problem hiding this comment.
Thank you for PR! Sorry for forgetting updating all these :/
I think there is still one humanize* function usage which is not updated https://github.com/rawagner/console/blob/dashboard-capacity-2/frontend/public/components/image-stream-tag.tsx#L44 .Should be const humanizedSize = _.isFinite(size) && humanizeBinaryBytes(size).string;
|
|
||
|
|
||
| export type MutatorFunction = (value: string | number, options?: any) => string; | ||
| export type HumanizeFunction = (value: string | number, initialUnit?: string, preferredUnit?: string) => { |
Owner
There was a problem hiding this comment.
We could reuse Humanize type from https://github.com/openshift/console/blob/a724ff96b98dbc76bc3fa0843915129ab953bca7/frontend/public/components/utils/index.tsx#L107 .
Author
There was a problem hiding this comment.
Oh, yeah that works too. Didn't realize that was there.
rawagner
pushed a commit
that referenced
this pull request
Dec 9, 2019
Adds test case to check cluster's health before and after adding capacity
rawagner
pushed a commit
that referenced
this pull request
Aug 17, 2021
rawagner
pushed a commit
that referenced
this pull request
Aug 17, 2021
…ants Bug 1993975: remove kubevirt dependants #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust to account for new return format of humanize functions in
frontend/public/components/utils/units.jsopenshift#1723 (comment)