Fix slow startup in qt_editor caused by QFontDatabase in background thread#3
Fix slow startup in qt_editor caused by QFontDatabase in background thread#3
Conversation
…hread Removed the Qt Font Database enrichment loop from AsyncFontLoader. Calling QFontDatabase().styles(family) for every installed font caused a massive performance bottleneck on startup, and executing GUI-related calls from a background QThread can cause lock contention and hanging issues in Qt. Co-authored-by: rayvy <29858688+rayvy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes the slow startup issue in the Qt Editor introduced by the font system implementation. The background font scanning thread was using
QtGui.QFontDatabase()to query styles for every font family in the registry, which caused severe UI blocking and lock contention since Qt GUI classes are not thread-safe and parsing hundreds of fonts is extremely slow. Removing this enrichment fixes the problem and allows the editor to launch quickly without hanging.PR created automatically by Jules for task 3494273643403831834 started by @rayvy