fixed issue 308 #310
Merged
fixed issue 308 #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhwanilvyas
reviewed
Sep 9, 2022
dist/resources/virtualAccounts.js
Outdated
| var data = { | ||
| status: 'closed' | ||
| }; | ||
| var data = {}; |
There was a problem hiding this comment.
I don't think we need to make changes in the dist folder. It should be updated when the build is run
Contributor
Author
There was a problem hiding this comment.
@dhwanilvyas i have an doubt , does it build automatically when user install this package from npmjs ?
There was a problem hiding this comment.
+1
@ankitdas13 Dist should be updating upon building the package
lib/resources/virtualAccounts.js
Outdated
| let data = { | ||
| status: 'closed' | ||
| } | ||
| let data = {} |
There was a problem hiding this comment.
suggestion: we can remove this variable itself if we're not sending any data in the request body?
sidag95
approved these changes
Sep 14, 2022
sidag95
left a comment
sidag95
left a comment
There was a problem hiding this comment.
LGTM
Do we need to update any docs for this? I.e. SDK docs?
Contributor
Author
No we dont need to update any doc. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue : #308
API reference : https://razorpay.com/docs/api/payments/smart-collect/#close-a-virtual-account