Updated changelog.md #322
Updated changelog.md #322
Conversation
CHANGELOG.md
Outdated
| - [Bugfix]: fix: passing `partial_payment` boolean issue when creating order [#311] | ||
| - Added Issue and feature templates | ||
| ### Patch Changes | ||
| - Close virtualaccount end point \[[`3e6daf3`](https://github.com/razorpay/razorpay-node/commit/3e6daf3c555f62eb23660a54eaae756e395ea3b6)]: |
There was a problem hiding this comment.
suggestion:
-
Fixed
virtualAccount.closefunction implementation -
Fixed
orders.createfunction by passingpartial_paymentboolean
There was a problem hiding this comment.
made these changes
There was a problem hiding this comment.
Lets start tagging who made these changes. Like how FE-universe or Blade does.
There was a problem hiding this comment.
#310 3e6daf3 : Thanks @ankitdas13 ! - Fixed virtualAccount.close function implementation
#311 653a278: Thanks @ankitdas13 ! - Fixed orders.create function by passing partial_payment boolean
There was a problem hiding this comment.
@ankitdas13 Sure, please update the changelog with the above, will approve
There was a problem hiding this comment.
@sidag95 It's done. Can you please approve?
CHANGELOG.md
Outdated
| - Added Issue and feature templates | ||
| ## 2.8.4 - 2022-11-21 | ||
|
|
||
| - [#310](https://github.com/razorpay/razorpay-node/pull/310) [`3e6daf3`](https://github.com/razorpay/razorpay-node/commit/3e6daf3c555f62eb23660a54eaae756e395ea3b6) : Thanks [@ankitdas13 ](https://github.com/snitin315)! - Fixed `virtualAccount.close` function implementation |
There was a problem hiding this comment.
suggestion: @ankitdas13 Please update Thanks [@ankitdas13 ](https://github.com/snitin315)! with your github account link 😅
There was a problem hiding this comment.
@sidag95 sorry i didnt saw that 😅 . i have updated the account link
There was a problem hiding this comment.
@ankitdas13 Last thing, why an extra space after @ankitdas13?
There was a problem hiding this comment.
@sidag95
With space @ankitdas13 !
Without space @ankitdas13!
Should i remove space ?
Patch Changes
3e6daf3]:partial_paymentboolean issue when creating order [653a278]: