adding projectRoot to options and resolve it #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jul 29, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Please add it to the documentation as well: https://github.com/react-native-community/cli/blob/master/docs/commands.md#start
Contributor
Author
|
done |
thymikee
approved these changes
Jul 30, 2019
thymikee
added a commit
that referenced
this pull request
Aug 1, 2019
* origin/master: imp: optimize gradle code generation (#603) v2.8.2 fix: corrects `srcDirs` to be compatible with Kotlin projects (#602) v2.8.1 fix: fallback to default terminal if wrong one passed (#601) fix: adding back `projectRoot` to option (#588) fix: init run instructions to show workspace (#566)
mmerickel
reviewed
Aug 13, 2019
|
|
||
| Specify port to listen on | ||
|
|
||
| #### `--projectRoot [list]` |
Contributor
There was a problem hiding this comment.
this isn't actually a list is it? looks like it's just forwarded to path.resolve() which doesn't take a list
Member
There was a problem hiding this comment.
Good point, it's a string. Mind sending a PR?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Following my PR from yesterday #572 , I forgot to include the --projectRoot option descriptor in the PR, which makes it non usable or documented in --help. This PR fixes it.
i also went ahead and added path.resolve to the parsing of it, and of --watchFolders.
Test Plan:
try using the cli start with custom project root set in metro config, it should load from the custom root. try using the cli start with --projectRoot that point to another directory (you can also check for relative path), it should override the metro config. try using the cli with a --watchFolders with relative paths, the folders you specified should be resolved and merged to those in the metro config.