imp: optimize gradle code generation #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sb-bartworx
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Member
|
@Salakar wdyt? |
thymikee
approved these changes
Aug 1, 2019
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
Works fine on a test project 👍
sb-bartworx
changed the title
sb-bartworx
changed the title
thymikee
reviewed
Aug 1, 2019
thymikee
added a commit
that referenced
this pull request
Aug 1, 2019
* origin/master: imp: optimize gradle code generation (#603) v2.8.2 fix: corrects `srcDirs` to be compatible with Kotlin projects (#602) v2.8.1 fix: fallback to default terminal if wrong one passed (#601) fix: adding back `projectRoot` to option (#588) fix: init run instructions to show workspace (#566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Small update / optimization for the code generation inside the gradle script.
Related to #600 and #602
Test Plan:
Tested in newly initialised project and with a Kotlin project
react-native init test && cd test && react-native run-android