Skip to content

imp: optimize gradle code generation #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 2 commits into from
Aug 1, 2019
Merged

imp: optimize gradle code generation #603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f42852
feat: optimize grdale code generation
Aug 1, 2019
018a91c
remove trailing slash
Aug 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/platform-android/native_modules.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ import groovy.json.JsonSlurper
import org.gradle.initialization.DefaultSettings

def generatedFileName = "PackageList.java"
def generatedFilePackage = "com.facebook.react"
def generatedFileContentsTemplate = """
package com.facebook.react;
package $generatedFilePackage;

import android.app.Application;
import android.content.Context;
Expand Down Expand Up @@ -229,8 +230,8 @@ ext.applyNativeModulesSettingsGradle = { DefaultSettings defaultSettings, String
ext.applyNativeModulesAppBuildGradle = { Project project, String root = ".." ->
autoModules.applyBuildGradle(project, root)

def generatedSrcDir = "generated/rncli/src/main/java"
def generatedCodeDir = new File(buildDir, "$generatedSrcDir/com/facebook/react")
def generatedSrcDir = new File(buildDir, "generated/rncli/src/main/java")
def generatedCodeDir = new File(generatedSrcDir, generatedFilePackage.replace('.', '/'))

task generatePackageList {
doLast {
Expand All @@ -244,7 +245,7 @@ ext.applyNativeModulesAppBuildGradle = { Project project, String root = ".." ->
sourceSets {
main {
java {
srcDirs += "build/$generatedSrcDir"
srcDirs += generatedSrcDir
}
}
}
Expand Down