Fix invalid regular expression on Windows #893
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0rr3sp3dr0
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Member
|
We usually need to keep Metro in CLI and RN in sync and, as far as I remember, using Metro 0.56+ with RN 0.60 won't work. |
Member
|
Duplicate of #864 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Metro had a bug that crashed React Native builds on Windows facebook/metro#468 that was solved on release v0.57.0.
React Native for Windows still needs to use React Native CLI 2.x as it is only compatible with React Native 0.60.6. I'm updating Metro version on this branch to solve this problem until React Native for Windows becomes compatible with the latest version of React Native.