Bumping metro packages to v0.57.0, which fixes a Windows CLI bug

[tad3j]

Windows CLI bug solved with facebook/metro@7c6f30b and released under v0.57.0.

Summary:

Updating all metro related packages to v0.57.0

Fixes #900
Fixes #853

Test Plan:

I ran test command bug seems like there are some issues:
Test Suites: 1 failed, 71 passed, 72 total
Tests: 5 failed, 2 skipped, 2 todo, 263 passed, 272 total
Snapshots: 6 failed, 20 passed, 26 total

Not sure if it's due to new metro version...

[grabbou]

Thanks for sending the PR over. Don't worry with the windows CI, it's been failing for some reason. I have to debug this myself when I get time after my windows.

CC: @TheSavior who would be the right person (or maybe that's you - in that case, awesome) to make sure this is safe to perform and distribute to 0.61?

[elicwhite]

I’m not sure. What is normally involved when bumping metro? What can go wrong?

[grabbou]

Historically, we've been cautious while doing so. There was this approach of not changing Metro versions when doing patch releases of React Native - only bumping for major.

If this is no longer the case and we can safely ship Metro as any other dependency, then I guess we should just do it.

[thymikee]

Had to remove usage of createBlacklist, because Metro got rid of it in 0.57.
For now I tested running and building on Android and it seems to work fine. iOS seems good as well.

[thymikee]

In my testing this looks good. But I'm afraid to publish this right before holiday :D

[SaeedZhiany]

@thymikee

Can you please merge and publish this PR? I'm working on a react and a react-native project at the same time and for some reason, I can't downgrade my node version.

Thanks

[thymikee]

FYI, this was patched in Metro 0.56 today: https://github.com/facebook/metro/releases/tag/v0.56.4. This PR is no longer necessary for 3.x, but I'll happily port it to 4.x soonish.

[grabbou]

Just a heads up. I am going to rebase next branch and we will merge this.

[thymikee]

@grabbou I think we could put Metro 0.57 in the v3.x, it worked well in my testing, but of course more is welcome.

Also, RN 0.62 uses Metro 0.57 or 0.58 so we need to account for that.

[grabbou]

Okay, we will need to bump to 0.58 for 0.62, so I guess we can experiment with bumping to 0.58 as well.

I would like to define a policy / steps involved in bumping Metro releases so that we can do it with more confidence. In theory, it shouldn't introduce new regressions if they follow semver.