Don't use deprecated createBlacklist metro api #919
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janicduplessis
requested review from
Esemesek,
grabbou and
thymikee
as code owners
Member
|
We have a PR open currently that bumps Metro to 0.57, see #864. When updating it I remember I verified the default blacklist and there was no need for us to actually use it. Can you please have a look? |
Contributor
Author
|
@thymikee This is only required for metro 0.58.0 that was released a few days ago. I think there is no harm in updating now since the blacklist file exists even in older metro versions. EDIT: Sorry I didn't read that right. Checked the PR and it makes sense, this isn't needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some legacy apis were removed in the latest metro release. The only one that seem to be affecting here is createBlacklist. we import it from the metro-config package instead. See facebook/metro@871cafb#diff-82e93cde29a5080883ceae93070af8feL13
Test Plan:
Tested that running the metro server works with metro 0.58.0