Skip to content

Conversation

@joshi-kaushal
Copy link
Member

Description

Fixes #263
I previously raised a similar PR #332, but this is the latest and better version of the issue.

This PR integrates Husky, Prettier, and ESLint with the repository. This will test staged files against the config before every commit.
The existing files are yet to be fixed. I believe in creating a different branch and collaboratively resolving those errors/warnings for doing it.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Aug 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ❌ Failed (Inspect) Nov 25, 2022 at 8:37AM (UTC)

@koustov
Copy link
Member

koustov commented Aug 20, 2022

I see this build time error
image

@koustov
Copy link
Member

koustov commented Aug 30, 2022

Hey @joshi-kaushal i would like to get this PR in. A long-time one. Could you please resolve the conflict and fix the build error? Then it will be ready for merge.

@joshi-kaushal
Copy link
Member Author

Hello @koustov, I am busy with a few other things rn. It would be really helpful if anyone could help me with this pr.

@joshi-kaushal
Copy link
Member Author

Hi @koustov

I can not see the preview or error log for this build. Where can I see those?

@joshi-kaushal
Copy link
Member Author

joshi-kaushal commented Nov 8, 2022

@Sachin-chaurasiya

@atapas
Copy link
Member

atapas commented Nov 8, 2022

  • kaushal)

Nice! Can we put dates also on these tasks by when we can tentatively complete them?

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 24, 2022

Deploy Preview for reactplayio failed.

Name Link
🔨 Latest commit 1fd1dba
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/6380506435a7820009a8b85e

@Sachin-chaurasiya Sachin-chaurasiya changed the base branch from main to release/code-cleanup November 25, 2022 08:29
@Sachin-chaurasiya Sachin-chaurasiya merged commit 291f2b8 into release/code-cleanup Nov 25, 2022
@Sachin-chaurasiya Sachin-chaurasiya deleted the feat/lint branch November 25, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress The work is in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature request]: Configure ESLint and Prettier

6 participants