-
-
Notifications
You must be signed in to change notification settings - Fork 934
Add Eslint, prettier and pre commit hook. #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
DO NOT MAKE ANY CHANGES TO THIS PR ( DO NOT UPDATE THE BRANCH ) |
|
hi @Sachin-chaurasiya! I was already working on the same issue. The work was on halt on PR #507. |
@joshi-kaushal , I think it will have a lot of changes and will be hard to manage, that's why I created separate PR and I have resolved a bunch of issues. If you want we can work on this collectively. |
|
Yes. That's why we decided to split this issue into two separate pull requests. First PR will configure the project and the other will solely focus on fixing linting/prettier issues from the existing codebase. |
@joshi-kaushal , I think we should sync up on this and decide how to approach this thing. |
|
Of course. Let's have a meeting sometime this week. |
|
As discussed with @joshi-kaushal, this PR will be the second patch for eslint and a prettier fix after we have merged the #507. |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist: