Skip to content

Conversation

@Sachin-chaurasiya
Copy link
Member

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Sachin-chaurasiya Sachin-chaurasiya self-assigned this Oct 29, 2022
@vercel
Copy link

vercel bot commented Oct 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-play ❌ Failed (Inspect) Nov 25, 2022 at 8:58AM (UTC)

@Sachin-chaurasiya
Copy link
Member Author

Sachin-chaurasiya commented Oct 29, 2022

DO NOT MAKE ANY CHANGES TO THIS PR ( DO NOT UPDATE THE BRANCH )

@joshi-kaushal
Copy link
Member

hi @Sachin-chaurasiya! I was already working on the same issue. The work was on halt on PR #507.

@Sachin-chaurasiya
Copy link
Member Author

Sachin-chaurasiya commented Oct 31, 2022

hi @Sachin-chaurasiya! I was already working on the same issue. The work was on halt on PR #507.

@joshi-kaushal , I think it will have a lot of changes and will be hard to manage, that's why I created separate PR and I have resolved a bunch of issues.

If you want we can work on this collectively.

@joshi-kaushal
Copy link
Member

Yes. That's why we decided to split this issue into two separate pull requests. First PR will configure the project and the other will solely focus on fixing linting/prettier issues from the existing codebase.

@Sachin-chaurasiya
Copy link
Member Author

Yes. That's why we decided to split this issue into two separate pull requests. First PR will configure the project and the other will solely focus on fixing linting/prettier issues from the existing codebase.

@joshi-kaushal , I think we should sync up on this and decide how to approach this thing.

@joshi-kaushal
Copy link
Member

Of course. Let's have a meeting sometime this week.

@Sachin-chaurasiya
Copy link
Member Author

Sachin-chaurasiya commented Nov 8, 2022

As discussed with @joshi-kaushal, this PR will be the second patch for eslint and a prettier fix after we have merged the #507.
I will push the updated eslint and prettier config in #507.
cc : @atapas @joshi-kaushal

@Sachin-chaurasiya Sachin-chaurasiya changed the base branch from main to release/code-cleanup November 25, 2022 08:34
@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as ready for review November 25, 2022 08:55
@Sachin-chaurasiya Sachin-chaurasiya merged commit 009aa37 into release/code-cleanup Nov 25, 2022
@Sachin-chaurasiya Sachin-chaurasiya deleted the linting branch November 25, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants