feat(mdxish): support tutorial tile in mdxish #1273
Conversation
maximilianfalco
changed the title
…to falco/cx-2640-support-tutorial-tile-in-mdxish
kevinports
left a comment
kevinports
left a comment
There was a problem hiding this comment.
The tutorial tile specific code seems good here, but had a question about the table cell parsing logic in this change set.
| /** Parses markdown in table cells */ | ||
| const cellParser = unified().use(remarkParse).use(remarkGfm); |
There was a problem hiding this comment.
Confused what this change has to do with supporting tutorial tiles in mdxish?
& why would we parse table content with a plain remarkParse/remarkGfm pipeline? I'd expect we'd still want to support readme flavored syntax within a table cell where possible. But I may be missing something here.
There was a problem hiding this comment.
Ah oops I think I branched this branch off of a table cell fix @eaglethrost made a while back. Will pull from next to remove this dif
There was a problem hiding this comment.
Yep okay fixed this by pulling from next -> 234ef04
…to falco/cx-2640-support-tutorial-tile-in-mdxish
2 participants
🧰 Changes
Add support for rendering legacy
tutorial-tile/recipemagic blocks🧬 QA & Testing
Create a magic blocks tutorial/recipe block in mdxish. The card should be rendered now.