fix(mdxish): fix magic blocks in lists #1274
Draft
+409
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to falco/mdxish-fix-magic-blocks-in-lists
maximilianfalco
commented
Dec 17, 2025
| }); | ||
|
|
||
| // TODO: unskip this test once recipe magic blocks are correctly supported | ||
| it.skip('should restore recipe block inside a list item', () => { |
Contributor
Author
There was a problem hiding this comment.
this and the test in L245 would only be unskipped once this PR (#1273) gets merged in!
maximilianfalco
commented
Dec 17, 2025
| expect(tableElement!.tagName).toBe('table'); | ||
| }); | ||
|
|
||
| // TODO: unskip this test once embed magic blocks are supported |
Contributor
Author
There was a problem hiding this comment.
this will be unskipped once #1258 is merged in!
maximilianfalco
commented
Dec 17, 2025
| }); | ||
|
|
||
| // TODO: unskip this test once callout magic blocks are correctly supported | ||
| it.skip('should restore callout block inside a list item', () => { |
Contributor
Author
There was a problem hiding this comment.
there is a small issue with callout magic blocks, Ive created a ticket here. will unskip this once that is resolved
…to falco/mdxish-fix-magic-blocks-in-lists
eaglethrost
reviewed
Jan 1, 2026
| }); | ||
| }); | ||
|
|
||
| it('should convert html content inside table cells as nodes in the ast', () => { |
Contributor
There was a problem hiding this comment.
Why is this test & the one in line 109 deleted?
eaglethrost
reviewed
Jan 1, 2026
| // Some extra children are added to the AST by the mdxish wrapper | ||
| expect(ast.children).toHaveLength(4); | ||
| expect(ast.children[2].type).toBe('element'); | ||
| expect(ast.children).toHaveLength(2); |
Contributor
There was a problem hiding this comment.
Thanks the AST looks cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Make sure all types of magic blocks follow lists when they are listed
🧬 QA & Testing