Remove burn bar + pool value table (#1025)#1030
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The functional diff matches issue #1025: it removes the burn bar, removes the pool value/milestone table, and cleans up now-unused helpers/imports. However, GitHub reports this PR as merge-conflicting, so Head cannot merge it as-is.
Findings
- [blocking] PR branch is currently not mergeable (
mergeable: CONFLICTING).- File: PR branch state
- Suggestion: Rebase or merge
mainintofeat/remove-burn-bar-1025, resolve the conflict, push the fix, and request re-review.
Decision
Request changes until the merge conflict is resolved. After that, the code diff should be quick to re-review.
realproject7
left a comment
There was a problem hiding this comment.
RE2 Verdict: REQUEST CHANGES
Summary
Code diff is clean and correctly implements #1025. All removed code (BurnBar, milestone table, helpers, constants, unused imports) has no remaining references. Version bump 1.3.0 → 1.3.1 is appropriate for a removal.
Findings
- [ok] BurnBar component, milestone table, and all associated helpers/constants fully removed with no dangling references.
- [ok] Unused imports (
useMemo,formatUsdValue) cleaned up. - [ok] Version bump correct (patch for removal).
- [blocking] PR has merge conflicts (
mergeable_state: dirty). Must rebase or merge main before this can land.
Decision
Request changes — agreeing with RE1. Once the merge conflict is resolved, the code itself is good to go.
Strip BurnBar component and "What happens as PLOT grows" milestone table from CampaignHero — milestone cards (#1027) will replace this visualization. Removes all associated helpers, constants, and unused imports. Bump version: 1.3.0 → 1.3.1 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
964c6ba to
bd1ce4b
Compare
realproject7
left a comment
There was a problem hiding this comment.
RE2 Re-review: APPROVE
Merge conflict resolved. Rebased diff now also correctly removes the AIRDROP_TEST_MODE import and the additional sections added to main since the original commit ("Your airdrop grows with $PLOT", "Four steps", "Not reached? Burned forever"). No dangling references. LGTM.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The rebase resolved the merge conflict, and the updated diff cleanly implements issue #1025. The burn bar, pool value table, related milestone sections, and now-unused helpers/imports are removed while the remaining hero content continues to flow directly into participant count.
Findings
- [ok] Burn bar and current MCap/pool value section removed.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Pool value / "Your airdrop grows with $PLOT" table and associated summary copy removed.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Branch is mergeable and CI is green (
lint-and-typecheck,e2e, Vercel checks passed).- File: PR checks
Decision
Approve. The PR matches #1025 acceptance criteria and is now mergeable with passing checks.
Summary
BurnBarcomponent ("If the campaign ended right now..." with red/green bar, burned/distributed percentages, current FDV and pool value)buildMilestoneRows,getCurrentBurnState,formatCompact), constants (MAX_SUPPLY,TIER_KEYS,CMC_RANKS), and unused imports (useMemo,formatUsdValue)Closes #1025
Test plan
🤖 Generated with Claude Code