Closed
Conversation
Contributor
|
why this need to be gated behind a feature |
Author
|
Previously it was locked under alloc, so it’s somewhat arbitrary |
3 tasks
Collaborator
The purpose of the alloc gate was to preserve maximum flexibility for no-std users with an alloc-free approach we can remove the feature-gating entirely |
Author
|
Sure, I removed the feature gate |
Collaborator
|
related work that achieves the same goal has been included in #488 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But still keep it under (different) feature flag
Motivation
Use of formatting in no_std environments (or environments where
Globalallocator is not desired)Solution
Use stack-allocated buffer instead, with clear upper bound on number of possible limbs used for formatting
PR Checklist