feat: remove "alloc" feature requirement from base_convert/fmt#488
feat: remove "alloc" feature requirement from base_convert/fmt#488prestwich merged 2 commits intorecmo:mainfrom
Conversation
CodSpeed Performance ReportMerging #488 will not alter performanceComparing Summary
|
f21de73 to
12eeb0d
Compare
7c97013 to
6d32165
Compare
|
As mentioned in #490 this a lot slower because of precomputing the highest power, then dividing that power and (bigint) division is slow; it looks like just computing le and reversing iteration is almost always faster. Do we want to feature gate the slow implementation to |
546965f to
2865594
Compare
Yes, i would appreciate this |
35016aa to
78e0c0f
Compare
|
Done |
|
the performance improvement in fmt/4096 is due to hoisting the self.base load to outside of the loop which has drastic consequences to the generated code: https://godbolt.org/z/Wzbsbf4Pb and the ones for 64 and 128 are due to the added fast paths i'll move these changes to a separate PR |
d1ee587 to
fec2814
Compare
fec2814 to
bfa02ea
Compare
Motivation
Alternative to #478 by making to_base_be not allocate directly.
Closes #478.
Needs #487 to gauge perf impact.Closes #294.
Solution
PR Checklist