Skip to content

chore: add fmt benches#487

Merged
prestwich merged 2 commits intorecmo:mainfrom
DaniPopes:fmt-benches
Jul 7, 2025
Merged

chore: add fmt benches#487
prestwich merged 2 commits intorecmo:mainfrom
DaniPopes:fmt-benches

Conversation

@DaniPopes
Copy link
Contributor

No description provided.

@DaniPopes DaniPopes requested a review from prestwich as a code owner July 5, 2025 17:50
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 5, 2025

CodSpeed Performance Report

Merging #487 will not alter performance

Comparing DaniPopes:fmt-benches (a97e5ab) with main (c7f7285)

🎉 Hooray! codspeed-rust just leveled up to 3.0.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 253 untouched benchmarks
🆕 42 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 base_convert/128/128/10/be N/A 13.9 ms N/A
🆕 base_convert/128/128/10/le N/A 3.5 ms N/A
🆕 base_convert/192/192/10/be N/A 22.5 ms N/A
🆕 base_convert/192/192/10/le N/A 9.4 ms N/A
🆕 base_convert/256/256/10/be N/A 33.6 ms N/A
🆕 base_convert/256/256/10/le N/A 18.4 ms N/A
🆕 base_convert/384/384/10/be N/A 65 ms N/A
🆕 base_convert/384/384/10/le N/A 47.6 ms N/A
🆕 base_convert/4096/4096/10/be N/A 132.7 ms N/A
🆕 base_convert/4096/4096/10/le N/A 129.6 ms N/A
🆕 base_convert/512/512/10/be N/A 110.1 ms N/A
🆕 base_convert/512/512/10/le N/A 91.7 ms N/A
🆕 base_convert/64/64/10/be N/A 8.3 ms N/A
🆕 base_convert/64/64/10/le N/A 615.7 µs N/A
🆕 fmt/binary/128 N/A 8.7 ms N/A
🆕 fmt/binary/192 N/A 12.5 ms N/A
🆕 fmt/binary/256 N/A 17.6 ms N/A
🆕 fmt/binary/384 N/A 25.8 ms N/A
🆕 fmt/binary/4096 N/A 9.2 ms N/A
🆕 fmt/binary/512 N/A 37.2 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@DaniPopes
Copy link
Contributor Author

DaniPopes commented Jul 6, 2025

They run instantly in codspeed but maybe they're too many? wdyt @Rjected @prestwich

@prestwich
Copy link
Collaborator

I think that having 180 benches just for base conversion and formatting is probably overkill and likely to create some noise. i'd prefer to cut that down a bit. Conversion is a 1-time cost and can be amortized in program life-cycle, and not the perf focus of the lib. let's have the majority of the benches focus on the math and allocations of using the uints

@DaniPopes
Copy link
Contributor Author

how about now?

@prestwich prestwich enabled auto-merge July 7, 2025 16:58
@prestwich prestwich merged commit 6618571 into recmo:main Jul 7, 2025
18 checks passed
@DaniPopes DaniPopes deleted the fmt-benches branch July 7, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants