Skip to content

perf: improve to_base_le#497

Merged
prestwich merged 1 commit intorecmo:mainfrom
DaniPopes:perf-to-le
Jul 25, 2025
Merged

perf: improve to_base_le#497
prestwich merged 1 commit intorecmo:mainfrom
DaniPopes:perf-to-le

Conversation

@DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Jul 17, 2025

Based on #488.

@codspeed-hq
Copy link

codspeed-hq bot commented Jul 17, 2025

CodSpeed Performance Report

Merging #497 will improve performances by ×2.1

Comparing DaniPopes:perf-to-le (130b916) with main (ae691f1)

Summary

⚡ 6 improvements
✅ 289 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
base_convert/4096/4096/10/be 133.4 ms 65.4 ms ×2
base_convert/4096/4096/10/le 129.6 ms 61.7 ms ×2.1
fmt/binary/4096 8.8 ms 5.3 ms +67.46%
fmt/decimal/4096 7.8 ms 4.2 ms +83.08%
fmt/hex/4096 8.4 ms 4.6 ms +80.78%
fmt/octal/4096 7.9 ms 4.4 ms +81.02%

@DaniPopes DaniPopes force-pushed the perf-to-le branch 6 times, most recently from 418273b to 30d87a3 Compare July 22, 2025 07:07
@DaniPopes DaniPopes force-pushed the perf-to-le branch 3 times, most recently from 18d8a64 to f15ae32 Compare July 22, 2025 16:05
@DaniPopes DaniPopes marked this pull request as ready for review July 22, 2025 16:14
@DaniPopes DaniPopes requested a review from prestwich as a code owner July 22, 2025 16:14
@prestwich prestwich merged commit 8d5e441 into recmo:main Jul 25, 2025
19 checks passed
@DaniPopes DaniPopes deleted the perf-to-le branch July 25, 2025 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

base_convert: If we keep track of leading zero limbs we can half iterations.

2 participants