Skip to content

make FilesystemRoot.initialize_from_disk() fail when given an incorrect path, instead of not initializing anything #60

@whyitfor

Description

@whyitfor

What is the problem? (Here is where you provide a complete Traceback.)
The current code is essentially:

for root, dirs, files in os.walk(root_path):
    <something>

Which does nothing when root_path doesn't exist.

It also does nothing when the path given corresponds to a file and not a directory.

Please provide some information about your environment.
N/A

If you've discovered it, what is the root cause of the problem?
See above.

How often does the issue happen?
Whenever an incorrect path is passed to FilesystemRoot.initialize_from_disk.

Are you interested in implementing it yourself?
No. This is a good first contributor issue!

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions