FilesystemRoot.initialize_from_disk path validation#64
Merged
EdwardLarson merged 1 commit intoOct 5, 2022
Merged
Conversation
…h does not exist or is a file
EdwardLarson
approved these changes
Oct 5, 2022
Contributor
EdwardLarson
left a comment
EdwardLarson
left a comment
There was a problem hiding this comment.
Thanks for tackling this!
Member
|
Hey @galbwe, thanks for being our first Hacktoberfest contributor! Do we have your permission to shout you out in the OFRAK newsletter and possibly on our Twitter? If so, would you prefer we link back to your GitHub, or to a different website/profile? |
Contributor
Author
|
@rds-jacob sure! My twitter handle is @wezthedev if you want to include that. Thanks! |
EdwardLarson
pushed a commit
to EdwardLarson/ofrak
that referenced
this pull request
Aug 2, 2023
…ct_metadata Add project metadata and save option
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Related Issue(s)
Closes #60
Please describe the changes in your request.
Adds validation of the path parameter passed to
FilesystemRoot.initialize_from_disk. Will raise aFileNotFoundErrorif the path is not found or is to a file instead of a directory.Anyone you think should look at this, specifically?
@whyitfor since they opened the issue