Skip to content

FilesystemRoot.initialize_from_disk path validation #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdwardLarson merged 1 commit into from
Oct 5, 2022
Merged

FilesystemRoot.initialize_from_disk path validation #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions ofrak_core/ofrak/core/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,16 @@ async def initialize_from_disk(
path: str,
):
root_path = os.path.normpath(path)

if not os.path.exists(root_path):
raise FileNotFoundError(
f"Could not initialize from disk. Root path does not exist: {root_path}"
)
if not os.path.isdir(root_path):
raise FileNotFoundError(
f"Could not initialize from disk. Found a file instead of a directory: {root_path}"
)

for root, dirs, files in os.walk(root_path):
for d in sorted(dirs):
absolute_path = os.path.join(root, d)
Expand Down