Skip to content

Several improvements to ofrak test coverage#146

Merged
EdwardLarson merged 1 commit into
masterfrom
maintenance/improve_test
Dec 16, 2022
Merged

Several improvements to ofrak test coverage#146
EdwardLarson merged 1 commit into
masterfrom
maintenance/improve_test

Conversation

@whyitfor
Copy link
Copy Markdown
Contributor

@whyitfor whyitfor commented Dec 15, 2022

Please describe the changes in your request.

  • Bump fun-coverage to 0.2.0
  • Fix signature of function in resource_model.py
  • Mark all methods of ResourceViewInterface as no cover (one was missed in Resource.get_offest_within_root #111)
  • Bump ofrak function coverage to 97

Anyone you think should look at this, specifically?

@whyitfor whyitfor force-pushed the maintenance/improve_test branch from 655655a to a042765 Compare December 15, 2022 22:40
- Bump fun-coverage to 0.2.0
- Fix signature of function in resource_model.py
- Mark all methods of ResourceViewInterface as no cover (one was missed in #111)
- Bump function coverage for ofrak to 97
@whyitfor whyitfor force-pushed the maintenance/improve_test branch from a042765 to 6773408 Compare December 15, 2022 23:08
@whyitfor whyitfor marked this pull request as ready for review December 15, 2022 23:08
@EdwardLarson EdwardLarson merged commit 30ec63c into master Dec 16, 2022
@whyitfor whyitfor deleted the maintenance/improve_test branch December 16, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants