Resource.get_offest_within_root#111
Merged
EdwardLarson merged 1 commit intoNov 17, 2022
Merged
Conversation
- Remove Resource.get_offest_within_root, an unused method which was originally removed in redballoonsecurity#69 - Mark ResourceViewInterface methods as no cover. They are really abstract methods, but are not marked a such because ResourceViewInterface already has a metaclass
whyitfor
force-pushed
the
maintenance/test_coverage
branch
from
c1a067d to
2b33651
Compare
EdwardLarson
approved these changes
Nov 17, 2022
whyitfor
added a commit
that referenced
this pull request
Dec 15, 2022
- Bump fun-coverage to 0.2.0 - Fix signature of function in resource_model.py - Mark all methods of ResourceViewInterface as no cover (one was missed in #111)
whyitfor
added a commit
that referenced
this pull request
Dec 15, 2022
- Bump fun-coverage to 0.2.0 - Fix signature of function in resource_model.py - Mark all methods of ResourceViewInterface as no cover (one was missed in #111)
whyitfor
added a commit
that referenced
this pull request
Dec 15, 2022
- Bump fun-coverage to 0.2.0 - Fix signature of function in resource_model.py - Mark all methods of ResourceViewInterface as no cover (one was missed in #111) - Bump function coverage for ofrak to 97
EdwardLarson
pushed a commit
that referenced
this pull request
Dec 16, 2022
- Bump fun-coverage to 0.2.0 - Fix signature of function in resource_model.py - Mark all methods of ResourceViewInterface as no cover (one was missed in #111) - Bump function coverage for ofrak to 97
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your request.
Remove Resource.get_offset_within_root