Remove unused Resource methods, add tests for existing methods#69
Merged
EdwardLarson merged 12 commits intoOct 17, 2022
Merged
Conversation
whyitfor
force-pushed
the
maintenance/resource
branch
from
b96078b to
f0256ac
Compare
EdwardLarson
reviewed
Oct 7, 2022
EdwardLarson
reviewed
Oct 7, 2022
EdwardLarson
suggested changes
Oct 7, 2022
Contributor
EdwardLarson
left a comment
EdwardLarson
left a comment
There was a problem hiding this comment.
Overlaps a bit with #40, not a problem, just pointing that out. Both PRs identified unnecessary interfaces.
whyitfor
force-pushed
the
maintenance/resource
branch
from
ca23b2d to
53a5cc5
Compare
- Resource.get_siblings is never used or tested - Resource.get_siblings_as_view is only used in one contrived documentation example
whyitfor
changed the title
Contributor
Author
|
@EdwardLarson I've addressed the comments and updated the PR to include full function test coverage for Resource. |
EdwardLarson
approved these changes
Oct 17, 2022
whyitfor
added a commit
to whyitfor/ofrak
that referenced
this pull request
Nov 17, 2022
- Remove Resource.get_offest_within_root, an unused method which was originally removed in redballoonsecurity#69 - Make abstract methods of ResourceViewInterface as such
whyitfor
added a commit
to whyitfor/ofrak
that referenced
this pull request
Nov 17, 2022
- Remove Resource.get_offest_within_root, an unused method which was originally removed in redballoonsecurity#69 - Mark ResourceViewInterface methods as no cover. They are really abstract methods, but are not marked a such because ResourceViewInterface already has a metaclass
EdwardLarson
pushed a commit
that referenced
this pull request
Nov 17, 2022
- Remove Resource.get_offest_within_root, an unused method which was originally removed in #69 - Mark ResourceViewInterface methods as no cover. They are really abstract methods, but are not marked a such because ResourceViewInterface already has a metaclass
EdwardLarson
pushed a commit
to EdwardLarson/ofrak
that referenced
this pull request
Aug 8, 2023
…it_scripts Feature/init scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Related Issue(s)
N/A
Please describe the changes in your request.
This PR removed the following unused (and untested) publish methods from
Resource:Documentation is updated to reflect these changes. Specifically the "Advanced ResourceView Usage" section was removed. These removed APIs can be easily reintroduced in the future if they prove to be functionally useful and when they have test coverage.
Finally tests were added to ensure that all
Resourcepublic methods are tested.The function test coverage for
ofrakenforced in CI was bumped from 80 to 83.Anyone you think should look at this, specifically?
No.