Refactor entropy.so.1 as C extension#150
Merged
EdwardLarson merged 5 commits intoDec 28, 2022
Merged
Conversation
…ols, removing the dependency on running the Makefile
rbs-jacob
requested changes
Dec 23, 2022
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
I like the portability, and really like that it falls back on a pure-Python implementation.
See some comments about testing, and a couple of other minor things.
rbs-jacob
approved these changes
Dec 25, 2022
alchzh
added a commit
to alchzh/ofrak
that referenced
this pull request
Jul 16, 2024
…edballoonsecurity#150) Maintains current API and automatic builds with setuptools. Extends setuptools build_ext command to add a `.1` to the end of extensions marked with ctypes to match the old behavior. Not sure if this modification is still needed.
1 task
rbs-jacob
pushed a commit
that referenced
this pull request
Jul 22, 2024
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Related Issue(s)
We used a Makefile to build a shared object and ctypes to import from it. The Makefile was not necessarily portable across systems and was an extra build step besides pip installing.
Please describe the changes in your request.
ofrak_corewhich makes setuptools build the C source when running e.g.pip install, so installation of this is a 1-linerentropy.so.1is removedAnyone you think should look at this, specifically?
@rbs-jacob for sure!