Return to using ctypes for entropy calculation (partially reverts #150)#483
Merged
rbs-jacob merged 5 commits intoJul 22, 2024
Merged
Conversation
…edballoonsecurity#150) Maintains current API and automatic builds with setuptools. Extends setuptools build_ext command to add a `.1` to the end of extensions marked with ctypes to match the old behavior. Not sure if this modification is still needed.
Contributor
Author
😌 |
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially reverted #150 so entropy C code is called with
ctypesagain, but maintaining the current API and automatic compilation bysetup.py.Please describe the changes in your request.
Extends setuptools build_ext command to add a
.1to the end of extensions marked with ctypes to match the old behavior. Not sure if this modification is still needed.Anyone you think should look at this, specifically?
@jstrieb