Revert using SUBALIGN(0) for .bss sections#431
Merged
whyitfor merged 2 commits intoFeb 28, 2024
Conversation
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
May 30, 2024
* Remove SUBALIGN(0) from bss linker script * Update changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
SUBALIGN(0)for.bsssectionsLink to Related Issue(s)
Please describe the changes in your request.
The
SUBALIGN(0)option was leading to the following linker errors when building AARCH64 patches:SUBALIGN(0)strips any alignment which is specified. It is not clear what issue was fixed by adding this originally. Future alignment issues should be fixed by setting the alignment of bss variables with the__attribute__ ((aligned()))attribute.Anyone you think should look at this, specifically?
@whyitfor