Skip to content

Revert using SUBALIGN(0) for .bss sections #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
whyitfor merged 2 commits into from
Feb 28, 2024
Merged

Revert using SUBALIGN(0) for .bss sections #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
784ff32
Remove SUBALIGN(0) from bss linker script
rbs-afflitto Feb 26, 2024
aca4f3b
Update changelog
rbs-afflitto Feb 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ofrak_patch_maker/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased](https://github.com/redballoonsecurity/ofrak/tree/master)

### Changed
- Removed `SUBALIGN(0)` for `.bss` sections

## [4.0.2](https://github.com/redballoonsecurity/ofrak/compare/ofrak-patch-maker-v.4.0.1...ofrak-patch-maker-v.4.0.2)
### Fixed
- Remove option to read or install toolchain.conf from/to "/etc/toolchain.conf" ([#342](https://github.com/redballoonsecurity/ofrak/pull/342))
Expand Down
2 changes: 1 addition & 1 deletion ofrak_patch_maker/ofrak_patch_maker/toolchain/gnu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def ld_generate_bss_section(
) -> str:
bss_section_name = ".bss"
return (
f" {bss_section_name} : SUBALIGN(0) {{\n"
f" {bss_section_name} : {{\n"
f" *.o({bss_section_name}, {bss_section_name}.*)\n"
f" }} > {memory_region_name}"
)
Expand Down