-
Notifications
You must be signed in to change notification settings - Fork 246
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/*` and requires one.Indicates an issue or PR lacks a `triage/*` and requires one.
Description
/kind bug
There exists some misunderstandings around the hotReloadCapable meaning.
On Odo:
- on cluster: When Run command is hoteloadCapable, Build and Run commands are executed only once
- on Podman, when Run command is hotReloadCapable, Run command only is executed only once.
- on both podman and cluster, the hotReloadCapable'ity of the Build command is not considered
On Devfile stacks:
- on Angular devfile (and similar), the Run command is marked as hotReloadCapable, but not the Build command. This is compatible with the behaviour of odo on cluster, but not on Podman (as the Build command should be executed only once).
After discussion with @tkral, we propose to disambiguate this by:
- Updating description of hotReloadCapable on devfile/api to:
- specify on which command it is supported: build, run, debug
- specify what is the behaviour for Build command vs Run/Debug commands
- clarify that it is a synonym of (must be ran only once)
- Updating Devfile stacks to set the Build commands as hotReloadCapable when they must be ran only once. #6747
- Fixing Odo on Cluster and Podman to run the Build command after source changes only when hotReloadCapable (of the Build command itself, not of the Run command) is false.
Related issues:
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/*` and requires one.Indicates an issue or PR lacks a `triage/*` and requires one.
Type
Projects
Status
Done ✅