fix: Java build status spinning forever#2214
Conversation
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
| echo: false, | ||
| focus: false | ||
| }; | ||
| presenterTask.isBackground = true; |
There was a problem hiding this comment.
When was this introduced in the API? Asking to know if this'll work in theia
There was a problem hiding this comment.
I think isBackground has been around for a while, and supported by Theia ( https://che-incubator.github.io/vscode-theia-comparator/status.html ). However, I'm guessing the terminal only recently started using the property to determine whether to have a spinning icon beside the terminal label ?
There was a problem hiding this comment.
isBackground was introduced four years ago, since this task is long-running, I believe it's correct to mark it as isBackground.
I'm guessing the terminal only recently started using the property to determine whether to have a spinning icon beside the terminal label ?
Yes, I tried some previous version e.g. 1.50 as below, there's no visualization of the state at that time, and terminals are in dropdown menu... It has been visualized since vscode refine the terminal UX to present all terminals together.
|
Theia doesn't show a spinning icon for the terminal at all and when installing vscode-java with this change in Theia, I see no visible difference, so it should be safe. I think this is more because Theia doesn't have a view that displays all terminals at once, but instead allows a user to select them from the command palette. I think this should be fine to merge. |
|
Thanks @Eskibear! |
3 participants
To fix microsoft/vscode-java-pack#769
Signed-off-by: Yan Zhang yanzh@microsoft.com