Skip to content

fix: Java build status spinning forever #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbricon merged 1 commit into from
Nov 17, 2021
Merged

fix: Java build status spinning forever #2214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/serverTaskPresenter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ async function getPresenterTaskExecution(): Promise<TaskExecution> {
echo: false,
focus: false
};
presenterTask.isBackground = true;
Copy link
Copy Markdown
Collaborator

@fbricon fbricon Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When was this introduced in the API? Asking to know if this'll work in theia

Copy link
Copy Markdown
Member

@rgrunber rgrunber Nov 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think isBackground has been around for a while, and supported by Theia ( https://che-incubator.github.io/vscode-theia-comparator/status.html ). However, I'm guessing the terminal only recently started using the property to determine whether to have a spinning icon beside the terminal label ?

Copy link
Copy Markdown
Contributor Author

@Eskibear Eskibear Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isBackground was introduced four years ago, since this task is long-running, I believe it's correct to mark it as isBackground.

I'm guessing the terminal only recently started using the property to determine whether to have a spinning icon beside the terminal label ?

Yes, I tried some previous version e.g. 1.50 as below, there's no visualization of the state at that time, and terminals are in dropdown menu... It has been visualized since vscode refine the terminal UX to present all terminals together.
image


return presenterTaskExecution = await tasks.executeTask(presenterTask);
}
Expand Down