Don't send settings with all telemetry events#3045
Merged
rgrunber merged 1 commit intoredhat-developer:masterfrom Apr 4, 2023
Merged
Don't send settings with all telemetry events#3045rgrunber merged 1 commit intoredhat-developer:masterfrom
rgrunber merged 1 commit intoredhat-developer:masterfrom
Conversation
rgrunber
reviewed
Apr 4, 2023
Member
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Change looks fine to me. Can you just rename getNonDefaultJavaSettings to something like getJavaSettingsForTelemetry ? Initially I may have wanted just the setting if they aren't the default, but it's probably easier to just emit the settings regardless of default or not.
Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
less-verbose-telemetry
branch
from
4cfdace to
9527ed1
Compare
Collaborator
Author
done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3044