Skip to content

Don't send settings with all telemetry events #3045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrunber merged 1 commit into from
Apr 4, 2023
Merged

Don't send settings with all telemetry events #3045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/telemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,19 @@ export namespace Telemetry {
if (!telemetryManager) {
throw new Error("The telemetry service for vscode-java has not been started yet");
}
const javaSettings = getJavaSettingsForTelemetry(workspace.getConfiguration());

let properties: any;
if (eventName === STARTUP_EVT) {
serverInitializedReceived = true;
properties= { ...data, ...javaSettings };
} else {
properties= { ...data};
}

const javaSettings = getNonDefaultJavaSettings(workspace.getConfiguration());

return telemetryManager.send({
name: eventName,
properties: { ...data, ...javaSettings }
properties
});
}

Expand All @@ -56,7 +60,7 @@ export namespace Telemetry {
}
}

function getNonDefaultJavaSettings(config: WorkspaceConfiguration) {
function getJavaSettingsForTelemetry(config: WorkspaceConfiguration) {
// settings whose values we can record
const SETTINGS_BASIC = [
"java.quickfix.showAt", "java.symbols.includeSourceMethodDeclarations",
Expand Down