Few fixes and small changes. #205
Conversation
Vizit0r
commented
Aug 19, 2019
Vizit0r
commented
- fix of OPENARRAYOFU16 and OPENARRAYOFS16 declarations
- DynArray "out of range" errors extended, now included info about curr index and array length
- uPSUtils - takilng ansi string length from 0 index - changed to correct Length() calling.
- added names forming for dynarrays when compiling.
2) DynArray "out of range" errors extended, now included info about curr index and array length 3) uPSUtils - takilng ansi string length from 0 index - changed to correct Length() calling. 4) added names forming for dynarrays when compiling.
| {$IFDEF CPUX64} | ||
| IPointer = IntPtr; | ||
| {$IFDEF VER140UP} | ||
| IPointer = NativeInt; |
| btString: | ||
| tbtstring(dest^) := PSGetAnsiString(Src, srctype); | ||
| btChar: tbtchar(dest^) := tbtchar(PSGetUInt(Src, srctype)); | ||
| btChar: tbtchar(dest^) := PSGetAnsiChar(Src, srctype); |
There was a problem hiding this comment.
@Vizit0r This change is not explained by the commit comment? Why was it made?
| if srctype.BaseType = btClass then | ||
| TObject(Dest^) := TObject(Src^) | ||
| else | ||
| if srctype.BaseType = btVariant then |
There was a problem hiding this comment.
@Vizit0r This change is not explained by the commit comment? Why was it made?
There was a problem hiding this comment.
canot say exactly, but i remember, that long time ago i have some bug with classes, thats why this line has been added. But that was really LONG time ago, so no details.
Are there any problems due to this fix observed?
| end else v := nil; | ||
| try | ||
| Result := Caller.InnerfuseCall(FSelf, p.Ext1, {$IFDEF FPC}TPSCallingConvention(Integer(cc) or 64){$ELSE}cc{$ENDIF}, MyList, v); | ||
| Result := Caller.InnerfuseCall(FSelf, p.Ext1, TPSCallingConvention(Integer(cc) or 64), MyList, v); |
There was a problem hiding this comment.
@Vizit0r This change is not explained by the commit comment? Why was it made?
There was a problem hiding this comment.
this change is need to explain for InnerfuseCall x86 that constructor called.
For InvokeCall.inc this has no matter.
And yes, it should be covered by conditional define USEINVOKECALL
1) fix of OPENARRAYOFU16 and OPENARRAYOFS16 declarations (#205)
3 participants
