Skip to content

Conversation

@Vizit0r
Copy link
Contributor

@Vizit0r Vizit0r commented Aug 22, 2019

...callers (x86, x64, powerpc etc) for Delphi 2010+.

Tested on Win x86&x64, Android, MacOS32 - no problems observed.

  1. Changes for correct MACOS compilation in Delphi

  2. few changes and fixes for correct PS work on D7.

…pc etc) for Delphi 2010+.

Tested on Win x86&x64, Android, MacOS32 - no problems observed.

2) Changes for correct MACOS compilation in Delphi

3) few changes and fixes for correct work on D7.
SysUtils, Classes, uPSRuntime, uPSDebugger, uPSUtils,
uPSCompiler, uPSC_dll, uPSR_dll, uPSPreProcessor;
uPSCompiler,
{$IF DEFINED (MSWINDOWS) OR Defined (UNIX) OR Defined (fpc)} uPSC_dll, uPSR_dll,{$IFEND}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still here? AFAIK this doesn't compile in d2..d7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiled in D7 normally.
About previous version have no idea - they cant be installed on Win7 x64.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_1
Screen for you from D7 :)

@Vizit0r
Copy link
Contributor Author

Vizit0r commented Aug 24, 2019

so, Carlo?

next pack awaiting :)

@carlokok carlokok merged commit 86a057c into remobjects:master Aug 26, 2019
ccy added a commit to ccy/pascalscript that referenced this pull request Nov 26, 2019
1)InvokeCall added, instead of all different callers (x86, x64, powerpc etc) for Delphi 2010+. (remobjects#207)

Tested on Win x86&x64, Android, MacOS32 - no problems observed.

2) Changes for correct MACOS compilation in Delphi

3) few changes and fixes for correct work on D7.
ccy added a commit to ccy/pascalscript that referenced this pull request Nov 26, 2019
1)InvokeCall added, instead of all different callers (x86, x64, powerpc etc) for Delphi 2010+. (remobjects#207)

Tested on Win x86&x64, Android, MacOS32 - no problems observed.

2) Changes for correct MACOS compilation in Delphi

3) few changes and fixes for correct work on D7.
Result:= Result + ParamList.Items[I] + ': ' +
PSVariantToString(NewTPSVariantIFC(FStack[Cardinal(Longint(StackBase) - Longint(I) - 1)], False), '') + '; ';
Result := tbtString(String(Result).Remove(Length(Result)-2));
// Result := tbtString(String(Result).Remove(Length(Result)-2));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vizit0r Why is this line commented now?

@martijnlaan
Copy link
Collaborator

martijnlaan commented Feb 18, 2020

@carlokok @Vizit0r and others:

Ever since this pull request got merged it seems that ROPS has gotten unstable. There have been quite some issues reported with it, some with merged fixes (#211, #213) but also some without merged fixes (#217, #218, #219). Now I don't really know if it's safe to update anymore and am considering to create a personal fork at 1f846a5, which is the commit before @Vizit0r's two big merged pull requests (this one and #205).

In hindsight, were these pull requests worth it? If not, would it be better to revert them?

It doesn't help that both pull requests contain various different and unrelated changes, making it much harder to check things.

@martijnlaan
Copy link
Collaborator

@Vizit0r @carlokok
I talked to Carlo and as he suggested added a PS_USECLASSICINVOKE which makes it possible to avoid InvokeCall.inc but this still leaves a bunch of unexplained changes. For example in #205 I count 4 unexplained changes.

martijnlaan pushed a commit that referenced this pull request Feb 20, 2020
….inc which was introduced by #207. Alse cleanup the case some of the directives here and make it work on AUTOREFCOUNT.
@Vizit0r
Copy link
Contributor Author

Vizit0r commented Mar 1, 2020

sorry gentlemens, i've been on work last 3,5 month with internet speed near zero.
Will read, analyze and answer soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants