-
Notifications
You must be signed in to change notification settings - Fork 194
1)InvokeCall added, instead of all different … #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pc etc) for Delphi 2010+. Tested on Win x86&x64, Android, MacOS32 - no problems observed. 2) Changes for correct MACOS compilation in Delphi 3) few changes and fixes for correct work on D7.
| SysUtils, Classes, uPSRuntime, uPSDebugger, uPSUtils, | ||
| uPSCompiler, uPSC_dll, uPSR_dll, uPSPreProcessor; | ||
| uPSCompiler, | ||
| {$IF DEFINED (MSWINDOWS) OR Defined (UNIX) OR Defined (fpc)} uPSC_dll, uPSR_dll,{$IFEND} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still here? AFAIK this doesn't compile in d2..d7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compiled in D7 normally.
About previous version have no idea - they cant be installed on Win7 x64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
so, Carlo? next pack awaiting :) |
1)InvokeCall added, instead of all different callers (x86, x64, powerpc etc) for Delphi 2010+. (remobjects#207) Tested on Win x86&x64, Android, MacOS32 - no problems observed. 2) Changes for correct MACOS compilation in Delphi 3) few changes and fixes for correct work on D7.
1)InvokeCall added, instead of all different callers (x86, x64, powerpc etc) for Delphi 2010+. (remobjects#207) Tested on Win x86&x64, Android, MacOS32 - no problems observed. 2) Changes for correct MACOS compilation in Delphi 3) few changes and fixes for correct work on D7.
| Result:= Result + ParamList.Items[I] + ': ' + | ||
| PSVariantToString(NewTPSVariantIFC(FStack[Cardinal(Longint(StackBase) - Longint(I) - 1)], False), '') + '; '; | ||
| Result := tbtString(String(Result).Remove(Length(Result)-2)); | ||
| // Result := tbtString(String(Result).Remove(Length(Result)-2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vizit0r Why is this line commented now?
|
@carlokok @Vizit0r and others: Ever since this pull request got merged it seems that ROPS has gotten unstable. There have been quite some issues reported with it, some with merged fixes (#211, #213) but also some without merged fixes (#217, #218, #219). Now I don't really know if it's safe to update anymore and am considering to create a personal fork at 1f846a5, which is the commit before @Vizit0r's two big merged pull requests (this one and #205). In hindsight, were these pull requests worth it? If not, would it be better to revert them? It doesn't help that both pull requests contain various different and unrelated changes, making it much harder to check things. |
….inc which was introduced by #207. Alse cleanup the case some of the directives here and make it work on AUTOREFCOUNT.
|
sorry gentlemens, i've been on work last 3,5 month with internet speed near zero. |

...callers (x86, x64, powerpc etc) for Delphi 2010+.
Tested on Win x86&x64, Android, MacOS32 - no problems observed.
Changes for correct MACOS compilation in Delphi
few changes and fixes for correct PS work on D7.