Skip to content

defer auth check until request time#118

Closed
zeke wants to merge 1 commit intomainfrom
defer-auth-check
Closed

defer auth check until request time#118
zeke wants to merge 1 commit intomainfrom
defer-auth-check

Conversation

@zeke
Copy link
Copy Markdown
Member

@zeke zeke commented Aug 8, 2023

Check for auth when an API request is made, instead of checking at runtime.

See replicate/llama-chat#19 (comment)

Check for auth when an API request is made, instead of checking at runtime.
@mattt
Copy link
Copy Markdown
Contributor

mattt commented Aug 8, 2023

Thanks for opening this up, @zeke. I remember seeing that mention, but it disappeared from my notification feed.

I opened an alternative that removes the check rather than deferring it. Interested to hear if you feel strongly one way or the other. #120

@zeke
Copy link
Copy Markdown
Member Author

zeke commented Aug 8, 2023

#120 looks good. Let's go with that. 👍🏼

Closing this.

@zeke zeke closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants