Skip to content

Don't throw error if auth isn't provided in client constructor#120

Merged
zeke merged 1 commit intomainfrom
mattt/remove-auth-check
Aug 8, 2023
Merged

Don't throw error if auth isn't provided in client constructor#120
zeke merged 1 commit intomainfrom
mattt/remove-auth-check

Conversation

@mattt
Copy link
Copy Markdown
Contributor

@mattt mattt commented Aug 8, 2023

Alternative to #118
Related to #76
Reverts #77

This PR updates the client constructor to not throw an error if the auth option isn't provided.

Unlike #118, this PR removes the check rather than deferring it to the time of request. I think the API should be responsible for communicating missing credentials with a 401. With #103, we should be set up to surfacing that error correctly.

@mattt mattt requested a review from zeke August 8, 2023 14:13
@zeke zeke merged commit 49f2486 into main Aug 8, 2023
@zeke zeke deleted the mattt/remove-auth-check branch August 8, 2023 16:00
@zeke
Copy link
Copy Markdown
Member

zeke commented Aug 8, 2023

$ npx np minor

  ✔ Prerequisite check
  ✔ Git
  ✔ Installing dependencies using npm
  ✔ Running tests using npm
  ✔ Bumping version using npm
  ✔ Publishing package using npm
  ✔ Pushing tags
  ✔ Creating release draft on GitHub

 replicate 0.16.0 published 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants