Update release workflow to build source and binary distributions#95
Merged
Update release workflow to build source and binary distributions#95
Conversation
Signed-off-by: Mattt Zmuda <mattt@replicate.com>
2a0c2be to
4a206f9
Compare
Contributor
Author
|
@bfirsh Any reason not to package a binary distribution alongside the source? When I ran this locally, the resulting filename had the suffix |
zeke
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #81
The current release workflow builds the Python package for distribution using the following command:
python -m build --sdist --outdir dist .Looking at the help text for the command, the default behavior is to build both source and binary distribution. By specifying
--sdist, we're opting out of a binary distribution, so we can remove it to opt back into that behavior.Going a step further, the default options use
distas an output directory, use the current directory as the source directory, and build source and binary distribution, which is what we're already doing. So we can get the desired behavior by running without any additional options:python -m build