optional cuda toolkit install#13
Merged
zeke merged 2 commits intoreplicate:mainfrom Oct 17, 2023
Merged
Conversation
Contributor
Author
|
Hi, I added just a fix to a typo in documentation, ready to be merged ; ) |
|
@zeke feel free to merge - I don't have write access. Also just a quick note, I'm still not 100% sure when (or if at all) you need the cuda toolkit install. Worth looking into |
Member
|
Sorry for the delay here folks! Thanks for the ping, @nateraw
That's fixed now. :) |
Member
|
Created a GitHub Release for this: https://github.com/replicate/setup-cog/releases/tag/v1.0.3 🎉 |
Closed
zeke
added a commit
that referenced
this pull request
May 17, 2024
This PR includes two breaking changes which I want to roll out in a new major version v2: 1. Changes the `install_cuda` input to default to false. Most models don't need CUDA at build time. Workflows are much faster without it. 1. Changes the default version of Cog installed by the Action from 0.8.6 to 0.9.7 Resolves #31 cc @luismavs and @nateraw who originally had the bright idea to make CUDA optional: #13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #9.