v2: Don't install CUDA by default (and upgrade to latest Cog)#37
Merged
Conversation
Update action.yml
Update README.md
Member
Author
|
Smoke testing this here: https://github.com/zeke/hello-world-cog/actions/runs/9120284202 If it succeeds I'm going to do this: |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR includes two breaking changes which I want to roll out in a new major version v2:
install_cudainput to default to false. Most models don't need CUDA at build time. Workflows are much faster without it.Resolves #31
cc @luismavs and @nateraw who originally had the bright idea to make CUDA optional: #13