Skip to content

v2: Don't install CUDA by default (and upgrade to latest Cog)#37

Merged
zeke merged 4 commits intomainfrom
do-not-install-CUDA-by-default
May 17, 2024
Merged

v2: Don't install CUDA by default (and upgrade to latest Cog)#37
zeke merged 4 commits intomainfrom
do-not-install-CUDA-by-default

Conversation

@zeke
Copy link
Copy Markdown
Member

@zeke zeke commented May 16, 2024

This PR includes two breaking changes which I want to roll out in a new major version v2:

  1. Changes the install_cuda input to default to false. Most models don't need CUDA at build time. Workflows are much faster without it.
  2. Changes the default version of Cog installed by the Action from 0.8.6 to 0.9.7

Resolves #31

cc @luismavs and @nateraw who originally had the bright idea to make CUDA optional: #13

@zeke
Copy link
Copy Markdown
Member Author

zeke commented May 16, 2024

Smoke testing this here: https://github.com/zeke/hello-world-cog/actions/runs/9120284202

If it succeeds I'm going to do this:

git checkout main
git fetch --all --tags
git tag v2.0.0
git tag v2 --force
git push --tags --force

@zeke zeke requested review from a team, mattt and technillogue May 16, 2024 23:09
@zeke
Copy link
Copy Markdown
Member Author

zeke commented May 16, 2024

Smoke test passed!

Screenshot 2024-05-16 at 16 13 15

@zeke zeke merged commit 0f18c46 into main May 17, 2024
@zeke zeke deleted the do-not-install-CUDA-by-default branch May 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wild idea: Default to NOT installing CUDA

1 participant